Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes dns problem to redirect them to proxy in test mode #1850

Merged
merged 2 commits into from Apr 24, 2024

Conversation

re-Tick
Copy link
Contributor

@re-Tick re-Tick commented Apr 24, 2024

Related Issue

  • DNS fails for the external calls in native and docker when the services are down

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

the eBPF code is dependent on the mode of keploy which is recieved from the user space code. But after the re-factor there were changes regarding the deprecation of the global mode state. Due to which the user space code is not sending the mode to eBPF code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Signed-off-by: re-Tick <jain.ritik.1001@gmail.com>
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouravkrosx
Copy link
Member

@re-Tick Failing of java linux pipeline is not related to the code changes, Merging this PR because of its urgency.

@gouravkrosx gouravkrosx merged commit 7e6c138 into main Apr 24, 2024
12 of 14 checks passed
@gouravkrosx gouravkrosx deleted the fix-dns branch April 24, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants