Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check for file type while counting test set indices #1918

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

shivamsouravjha
Copy link
Contributor

Related Issue

  • Read only dirs while calculating indices.

Closes: #1917

Describe the changes you've made

While calculating indices we must just check for the folder types.

Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
@shivamsouravjha shivamsouravjha changed the title chore: check for file type for finding indices chore: check for file type while counting test set indices Jun 3, 2024
Copy link
Member

@gouravkrosx gouravkrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gouravkrosx gouravkrosx merged commit 43bc866 into main Jun 3, 2024
18 checks passed
@gouravkrosx gouravkrosx deleted the shivam/fileCheck branch June 3, 2024 07:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: read indices checks file too instead of just checking test set
2 participants