-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add race in docker and native #1952
Conversation
c5595d2
to
d71b2a4
Compare
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
c886532
to
7c50cca
Compare
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
a03cc07
to
f38aeca
Compare
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
.github/workflows/java_linux.yml
Outdated
@@ -9,7 +9,7 @@ jobs: | |||
|
|||
- name: Build Keploy binary | |||
run: | | |||
go build -tags=viper_bind_struct -o keployv2 | |||
go build -tags=viper_bind_struct -o keployv2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are not adding race flag here ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added the same
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Closes: #1467
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)