Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test-bench for express-mongodb application #1964

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sarthaksarthak9
Copy link
Member

@sarthaksarthak9 sarthaksarthak9 commented Jun 13, 2024

Related Issue

  • Info about Issue or bug

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: sarthaksarthak9 <sarthaknegi908@gmail.com>
Copy link

github-actions bot commented Jun 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@sarthaksarthak9
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@gouravkrosx
Copy link
Member

@sarthaksarthak9 You've added only one pipeline for the sample application, it should be 2 covering both cases. Please refer to the older pipeline for that.

@sarthaksarthak9
Copy link
Member Author

sarthaksarthak9 commented Jun 28, 2024

@gouravkrosx , I need a clarity here. The pipeline which I refer is this . I did similar. For two cases do you mean I
have to cover 2 application ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants