Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-196 | add path prefix #215

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Issue-196 | add path prefix #215

merged 3 commits into from
Oct 19, 2022

Conversation

sreekesh93
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 12, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@sreekesh93
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sreekesh93
Copy link
Contributor Author

recheck

Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@slayerjain slayerjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ensure to change the variable name in the UI repo PR too :)

@slayerjain
Copy link
Member

Hi @sreekesh93 you would need to update the PATH_PREFIX in the UI repo too.

@slayerjain
Copy link
Member

also, your DCO is failing. Please follow the steps as mentioned here - https://github.com/keploy/keploy/pull/215/checks?check_run_id=8977798842

@slayerjain
Copy link
Member

@sreekesh93 2 comits are still not signed and thus DCO is failing.

sreekesh93 and others added 3 commits October 19, 2022 14:29
Signed-off-by: sreekesh93 <sreekeshsbkv@gmail.com>
Signed-off-by: sreekesh93 <sreekeshsbkv@gmail.com>
Signed-off-by: sreekesh93 <sreekeshsbkv@gmail.com>
@sreekesh93
Copy link
Contributor Author

recheck

@sreekesh93
Copy link
Contributor Author

@slayerjain I have signedoff all commits, but still the DCO is failing, can you please help me here?

@slayerjain
Copy link
Member

@sreekesh93 all good now. thanks a lot for the PR! ❤️

@slayerjain slayerjain merged commit cc9cc81 into keploy:main Oct 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants