Keploy server version #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I have read the CLA Document and I hereby sign the CLA |
slayerjain
added a commit
that referenced
this pull request
Oct 16, 2022
…tartup Signed-off-by: Pankhudi Bhonsle <psbhonsle08@gmail.com>
Signed-off-by: Pankhudi Bhonsle <psbhonsle08@gmail.com>
PankhudiB
force-pushed
the
keploy-server-version
branch
from
ea7b32d
to
9d6c342
Compare
slayerjain
requested changes
Oct 19, 2022
| @@ -22,7 +22,9 @@ jobs: | |||
| go-version: 1.17 | |||
|
|
|||
| - name: Build | |||
| run: go build -v ./... | |||
| run: | | |||
| git_hash=$(git rev-parse --short "$GITHUB_SHA") | |||
There was a problem hiding this comment.
@PankhudiB as discussed in the issue thread. We should have both the commit-sha and the git-tag logged for the version. We mostly use git-tag for versions but adding commit-sha can. help identify unreleased builds.
| @@ -7,7 +7,10 @@ import ( | |||
| "go.keploy.io/server/server" | |||
| ) | |||
|
|
|||
| // Version will be injected during go build with ldflag | |||
| var Version = "" | |||
There was a problem hiding this comment.
this should also have a default value, maybe something like development
slayerjain
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #206
Describe the changes you've made
Log the version during keploy server startup. Inject the version during go build with ldflags
Type of change
Checklist:
Local run output by passing dummy version: