feat: option to name test cases #903
Conversation
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
|
Give your best to resolve the code scanning errors and as this feature is new we must mention this in some section in readme. |
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
|
@charankamarapu Hey how do you run codeql workflow locally ? |
|
you can run the github action https://github.com/keploy/keploy/blob/main/.github/workflows/codeql.yml locally . Use tools like act . |
@AkashKumar7902 you can add the documentation for this feature by making a PR to docs repo. |
|
@nehagup sure will do that ! |
|
Hey @AkashKumar7902 can you comment on the issue of this PR so that I can assign the issue to you? |
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pkg/platform/yaml/yaml.go
Outdated
| if err != nil { | ||
| ys.Logger.Error("failed to open the created yaml file", zap.Error(err), zap.Any("yaml file name", fileName)) | ||
| ys.Logger.Error("failed to open the created yaml file", zap.Error(err), zap.Any("yaml file name", fileName)) // lgtm [go/clear-text-logging] |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
pkg/platform/yaml/yaml.go
Outdated
| return err | ||
| } | ||
| data = append(data, d...) | ||
|
|
||
| _, err = file.Write(data) | ||
| if err != nil { | ||
| ys.Logger.Error("failed to write the yaml document", zap.Error(err), zap.Any("yaml file name", fileName)) | ||
| ys.Logger.Error("failed to write the yaml document", zap.Error(err), zap.Any("yaml file name", fileName)) // lgtm [go/clear-text-logging] |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
|
hey @AkashKumar7902 the github action is failing due to this issue #964 . I will merge this PR once that issue is resolved. |
Related Issue
Closes: #880
Describe the changes you've made
Added the code to fetch the value from key: Keploy_Test_Name passed in the header of the request, and changed the value of
tcsNamewith the value of our key since the variable is passed to the write .Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)N/A
Checklist:
Screenshots (if any)