Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove stopper from hooks #944

Merged
merged 3 commits into from
Oct 4, 2023
Merged

fix: remove stopper from hooks #944

merged 3 commits into from
Oct 4, 2023

Conversation

charankamarapu
Copy link
Member

Related Issue

  • Info about Issue or bug

Closes: #938

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

  1. Removed stopper from hooks and using it only in cmd layer
  2. Added checks before stopping hooks and proxy for both stopping due to interrupt and stopping forcefully due to app error. So that only one gets executed.
  3. Added a logger in case of command error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Signed-off-by: charankamarapu <kamarapucharan@gmail.com>
Copy link
Contributor

@re-Tick re-Tick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if !stoppedProxy {
select {
case <-stopper:
abortStopHooksForcefully = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the changes, here the boolean should be assigned true since, the application and proxy are gracefully shutdown here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@charankamarapu charankamarapu merged commit d5a3598 into keploy:main Oct 4, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
@charankamarapu charankamarapu deleted the remove-stopper branch October 4, 2023 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: when user application handles interrupt keploy logs are improper
2 participants