Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove channel from stopper #953

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: remove channel from stopper #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/service/record/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ func (r *recorder) CaptureTraffic(path string, appCmd, appContainer, appNetwork
}

// Channels to communicate between different types of closing keploy
abortStopHooksInterrupt := make(chan bool) // channel to stop closing of keploy via interrupt
exitCmd := make(chan bool) // channel to exit this command
abortStopHooksForcefully := false // boolen to stop closing of keploy via user app error
abortStopHooksInterrupt := make(chan bool) // channel to stop closing of keploy via interrupt
exitCmd := make(chan bool) // channel to exit this command
abortStopHooksForcefully := false // boolen to stop closing of keploy via user app error

select {
case <-stopper:
Expand Down Expand Up @@ -120,7 +120,7 @@ func (r *recorder) CaptureTraffic(path string, appCmd, appContainer, appNetwork
abortStopHooksForcefully = true
loadedHooks.Stop(false)
ps.StopProxyServer()
exitCmd <- true
return
case <-abortStopHooksInterrupt:
}
<-exitCmd
Expand Down
Loading