Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk build, package.json): Added .proto file as a part of build files and used it in grpc connection. #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(sdk build, package.json): Added .proto file as a part of build files and used it in grpc connection. #53

wants to merge 3 commits into from

Conversation

Hermione2408
Copy link
Member

Previously we were using cp command to copy services.proto file from proto folder to dist folder but cp command doesnt work for windows and hence the build fails in windows. I added "copy-files" script which uses copyfiles npm module to copy proto file and is OS independent.

fix keploy/keploy#372

@re-Tick
Copy link
Contributor

re-Tick commented Mar 1, 2023

Hi @Hermione2408, Please git rebase to pass DCO. You can follow the 3 steps mentioned in the failing DCO job

@re-Tick
Copy link
Contributor

re-Tick commented Mar 1, 2023 •
edited

I think that we should include .proto file in our "files" of package.json to include them in the npm build files.
Screenshot 2023-03-01 at 10 19 10 PM
Reference

And use relative path to that for grpcClient connection.

@Hermione2408 Hermione2408 changed the title fix(sdk build, package.json): added a copy-files script which is OS independent fix(sdk build, package.json): Added .proto file as a part of build files and used it in grpc connection. Mar 1, 2023
@Hermione2408
Copy link
Member Author

@re-Tick I have updated the PR with the changes Please review it and let me know if this need any changes.

@re-Tick
Copy link
Contributor

re-Tick commented Mar 2, 2023 •
edited

Hi @Hermione2408, Can we use the same "services.proto" file from photo directory instead of new "grpc.proto".

@Hermione2408
fix(sdk build, package.json): added a copy-files script which is OS i…
a78de98 
…ndependent

Previously we were using cp command to copy services.proto file from proto folder to dist folder but
cp command doesnt work for windows and hence the build fails in windows. I added "copy-files" script
which uses copyfiles npm module to copy proto file and is OS independent.

fix #51

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
fix(package.json, mock.ts, keploy.ts, grpc.proto): added proto file i…
71a5fc7 
…n build for grpc connection

Added .proto file as a part of build file and used it in grpc connection.

fix #51

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
fix: adding serives.proto instead of new grpc.proto
4b580a2 
fix #51

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
Copy link
Member Author

Hey @re-Tick do you mean something like this?

@re-Tick
Copy link
Contributor

re-Tick commented Mar 3, 2023 •
edited

Yes @Hermione2408. Have you built and tested your changes locally? LGTM. Please add the link to the PR in GSOC/2023 task list of typescript-sdk project.

@Hermione2408
Copy link
Member Author

Yes I have built and tested my changes locally ,Its working fine.

@re-Tick re-Tick added gsoc Google Summer of Code Don't Merge Not to be merged until gsoc results labels Mar 6, 2023
@Sonichigo Sonichigo added the Accepted PR is reviewed and Accepted label Mar 6, 2023
@re-Tick re-Tick added Accepted PR is reviewed and Accepted and removed Accepted PR is reviewed and Accepted labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results gsoc Google Summer of Code
Projects
None yet
Milestone
No milestone
3 participants
@Hermione2408 @re-Tick @Sonichigo