Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-fetch): empty response #60

Merged
merged 1 commit into from
May 24, 2023
Merged

fix(node-fetch): empty response #60

merged 1 commit into from
May 24, 2023

Conversation

G0maa
Copy link
Contributor

@G0maa G0maa commented Mar 9, 2023

  • fixes [bug]: Empty response for node-fetch http call keploy#376
  • I'm not entirely sure about the cases where we create a new context.
    • Since this is a dependency I think we shouldn't create one? (in all cases off/record/test) and only create context when we have the main app (i.e. express) integrated in code.
  • I treated it like the switch-case code below when it's off.

@G0maa
fix(node-fetch): empty response
6e6b0c6 
Signed-off-by: G0maa <midomaxgomaa@gmail.com>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 9, 2023 •
edited
Loading

Hi @G0maa, yes this should be the expected behaviour. LGTM

Please mention this PR in the GSOC/2023 task list of TS-SDK.

@G0maa
Copy link
Contributor Author

G0maa commented Mar 9, 2023 •
edited
Loading

Done @re-Tick : keploy/gsoc#34

@re-Tick re-Tick added Don't Merge Not to be merged until gsoc results Accepted PR is reviewed and Accepted labels Mar 9, 2023
@re-Tick re-Tick merged commit ac3de81 into keploy:main May 24, 2023
@re-Tick re-Tick mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results
Projects
None yet
Milestone
No milestone
2 participants
@G0maa @re-Tick