Add env vars for uniform registration also to helm chart #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeahservice
requested review from
adriangonciarz,
christian-kreuzberger-dtx and
jetzlstorfer
as code owners
Signed-off-by: Dominik Augustin <dominik.augustin@dynatrace.com>
yeahservice
force-pushed
the
fix/uniform-registration-with-helm-chart
branch
from
921f6eb
to
f403038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes from #52 the distributor configuration for the uniform registration feature was added to
deploy/service.yaml. This PR adds the configuration changes also to the helm chart.The labels were changed to use
keptn-service.labelsinstead ofkeptn-service.selectorLabels, becausekeptn-service.labelscontains more labels, in particular theapp.kubernetes.io/versionlabel which is needed for the uniform registration envVERSION.