Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set new documentation approach live #1007

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Mar 8, 2023

set the urls properly for the new page.

Update the github_branch to point always to the current branch, which netlify used for a build

set the urls properly for the new page.

Update the github_branch to point always to the current branch,
which netlify used for a build

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit a2ca5ce
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6408732437809b00083a34e5
😎 Deploy Preview https://deploy-preview-1007--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aepfli
Copy link
Member Author

aepfli commented Mar 8, 2023

the builds are failing, as the domains are not setup currently :)

@aepfli aepfli added the documentation Improvements or additions to documentation label Mar 8, 2023
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aepfli aepfli merged commit f3511f1 into keptn:main Mar 13, 2023
This was referenced Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants