fix: htmltest error for newly created documents #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTMLTest will complain, when we create new documentation pages, as they are not within the git repository. As we used to display the edit and create issue links pointing to the main branch, our build would fail. With this change, we will deactivate the rendering of those edit links, when invoked via make target. This means locally and with GitHub Actions, we will not see them. But netlify etc will render them properly. Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
requested review from
thisthat,
thschue,
bacherfl and
StackScribe
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
StackScribe
approved these changes
Mar 8, 2023
thisthat
approved these changes
Mar 9, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTMLTest will complain, when we create new documentation pages, as they are not within the git repository. As we used to display the edit and create issue links pointing to the main branch, our build would fail.
With this change, we will deactivate the rendering of those edit links, when invoked via make target. This means locally and with GitHub Actions, we will not see them. But netlify etc will render them properly.