fix: adapted patch for mutating webhook to correctly add release namespace to exclusions #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…space to exclusions Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thisthat
previously approved these changes
Mar 13, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 56.61% 58.73% +2.11%
==========================================
Files 92 124 +32
Lines 8520 9910 +1390
==========================================
+ Hits 4824 5821 +997
- Misses 3564 3877 +313
- Partials 132 212 +80 see 36 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Mar 14, 2023
thisthat
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further, this PR modifies the minimum version check for K8s to also allow prerelease versions of K8s, since I ran into an error telling me that the chart can not be installed on
v1.25.6-gke.1000