docs: cleanup after theme migration #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aepfli
force-pushed
the
docs/cleanup-after-theme-migration
branch
from
674cabe
to
80b46e8
Compare
github-actions
bot
added
cert-manager
documentation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
==========================================
- Coverage 59.15% 59.06% -0.09%
==========================================
Files 128 128
Lines 10035 10035
==========================================
- Hits 5936 5927 -9
- Misses 3884 3890 +6
- Partials 215 218 +3 see 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
aepfli
force-pushed
the
docs/cleanup-after-theme-migration
branch
3 times, most recently
from
94d466e
to
90cf1d8
Compare
aepfli
force-pushed
the
docs/cleanup-after-theme-migration
branch
2 times, most recently
from
1e4f9c6
to
775a65f
Compare
aepfli
requested review from
thisthat,
thschue,
bacherfl,
StackScribe,
mowies and
philipp-hinteregger
as code owners
|
@aepfli please provide a valid description where you explain what you did here :) |
mowies
reviewed
Apr 4, 2023
aepfli
force-pushed
the
docs/cleanup-after-theme-migration
branch
from
4677b8e
to
0fdf584
Compare
mowies
previously approved these changes
Apr 4, 2023
Migrated theme, and now we can use a proper template Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: Simon Schrottner <simon.schrottner@gmail.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
docs/cleanup-after-theme-migration
branch
from
0fdf584
to
2171274
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mowies
approved these changes
Apr 4, 2023
thisthat
approved these changes
Apr 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this pull request, we finalize the migration of our hugo theme tooling.
We extracted the theme into its own repository. And we cleaned it up from KLT-specific configuration. As an aftermath, we must set KLT-specific configurations within this repository. Additionally we centralized the docs release action also within the repository, and are now using the one from the docs-tooling repo
KLT-specifics are:
closes: #1013