Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): introduce retry logic for KeptnTasks #1088

Merged
merged 6 commits into from
Mar 24, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes: #64 #667

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fb53dbc
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/641b1862bd09dd0008ef6b34
😎 Deploy Preview https://deploy-preview-1088--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1088 (11b50a4) into main (8a77f00) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
+ Coverage   58.89%   59.05%   +0.15%     
==========================================
  Files         126      126              
  Lines       10007    10023      +16     
==========================================
+ Hits         5894     5919      +25     
+ Misses       3894     3888       -6     
+ Partials      219      216       -3     
Impacted Files Coverage Δ
...is/lifecycle/v1alpha3/keptntaskdefinition_types.go 100.00% <ø> (ø)
...r/apis/lifecycle/v1alpha3/zz_generated.deepcopy.go 0.00% <ø> (ø)
...perator/apis/lifecycle/v1alpha3/keptntask_types.go 97.59% <100.00%> (+0.12%) ⬆️
operator/controllers/common/taskhandler.go 79.71% <100.00%> (+3.19%) ⬆️
.../controllers/lifecycle/keptntask/function_utils.go 78.18% <100.00%> (+0.40%) ⬆️
...rator/controllers/lifecycle/keptntask/job_utils.go 40.54% <100.00%> (+2.22%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.61% <70.00%> (+0.57%) ⬆️
lifecycle-operator 78.52% <100.00%> (+0.11%) ⬆️
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the feat/667/taks-retry-logic branch 2 times, most recently from 44763b7 to 4e4a526 Compare March 22, 2023 15:27
@odubajDT odubajDT marked this pull request as ready for review March 23, 2023 09:28
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
…tnTask

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT odubajDT merged commit e49b5a3 into keptn:main Mar 24, 2023
@keptn-bot keptn-bot mentioned this pull request Mar 24, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make timeouts and retries configurable for function executions
3 participants