Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct control-plane label for metrics-operator #1147

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

nlamirault
Copy link
Contributor

Fix #1106

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 75291a0
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642a8431ef81f20008a6ecce
😎 Deploy Preview https://deploy-preview-1147--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/lifecycle/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nlamirault nlamirault changed the title Fix: control-plane label for metrics-operator fix: control-plane label for metrics-operator Mar 29, 2023
Fix keptn#1106

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1147 (75291a0) into main (3859059) will increase coverage by 2.39%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   56.68%   59.07%   +2.39%     
==========================================
  Files          92      128      +36     
  Lines        8500    10041    +1541     
==========================================
+ Hits         4818     5932    +1114     
- Misses       3548     3893     +345     
- Partials      134      216      +82     

see 47 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (?)
component-tests 59.97% <ø> (-1.88%) ⬇️
lifecycle-operator 78.48% <ø> (?)
metrics-operator 77.57% <ø> (?)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title fix: control-plane label for metrics-operator fix: use correct control-plane label for metrics-operator Apr 3, 2023
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label metrics-controller instead of metrics-operator
3 participants