Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): fix otel collector URL setup #1262

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Apr 20, 2023

Closes #1261

With these changes the traces should be exported correctly again:

Screenshot 2023-04-20 at 16 53 59

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 14e027e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64414d4a852d5e0007a99c67
😎 Deploy Preview https://deploy-preview-1262--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1262 (6dd0a25) into main (497e57e) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
+ Coverage   59.19%   59.41%   +0.21%     
==========================================
  Files         137      137              
  Lines       10267    10269       +2     
==========================================
+ Hits         6078     6101      +23     
+ Misses       3960     3941      -19     
+ Partials      229      227       -2     
Impacted Files Coverage Δ
operator/controllers/common/otel_utils.go 75.22% <100.00%> (+4.58%) ⬆️
...ator/controllers/options/keptnconfig_controller.go 81.57% <100.00%> (-0.93%) ⬇️

... and 5 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.71% <ø> (-0.58%) ⬇️
lifecycle-operator 78.19% <100.00%> (+0.16%) ⬆️
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review April 20, 2023 15:06
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit c3754b7 into keptn:main Apr 24, 2023
@bacherfl bacherfl deleted the fix/keptn-config branch April 24, 2023 06:31
@keptn-bot keptn-bot mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otel Collector URL is not applied when set in KeptnConfig
3 participants