Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include reason for failed evaluations in OTel events #1339

Closed
bacherfl opened this issue May 2, 2023 · 0 comments · Fixed by #1341
Closed

Include reason for failed evaluations in OTel events #1339

bacherfl opened this issue May 2, 2023 · 0 comments · Fixed by #1341
Assignees
@bacherfl
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.7.1

Comments

@bacherfl
Copy link
Member

bacherfl commented May 2, 2023

Currently, we do see it in the OTel trace if an evaluation has failed, however the event description does not include the reason why e.g. a particular value of a KeptnMetric caused the evaluation to fail, as seen in the following screenshot:

Screenshot 2023-05-02 at 11 17 53

The goal of this ticket is to extend the description to include the EvaluationTarget property (see

lifecycle-toolkit/operator/apis/lifecycle/v1alpha3/keptnevaluationdefinition_types.go

Line 33 in 27439ff

EvaluationTarget string `json:"evaluationTarget"`
)
@bacherfl bacherfl added the status: ready-for-refinement Issue is relevant for the next backlog refinment label May 2, 2023
@thisthat thisthat added enhancement New feature or request good first issue Good for newcomers labels May 2, 2023
@thisthat thisthat added this to the 0.9 milestone May 2, 2023
@thisthat thisthat modified the milestones: 0.9, 0.8 May 2, 2023
@thisthat thisthat removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label May 2, 2023
@bacherfl bacherfl mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bacherfl bacherfl

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.7.1
Development

Successfully merging a pull request may close this issue.

feat(operator): add information about evaluation target in status bacherfl/lifecycle-controller
2 participants
@thisthat @bacherfl