-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create pre/post-deploy getting started #1362
docs: create pre/post-deploy getting started #1362
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@aepfli markdown checks seem to be failing (from what I interpret) because /docs/readme.md contains a link to localhost.
|
The checks only needs one minute, and most of the time it is actually the setup rather than the test itself, i do not see a lot of benefit in improving this. the investments vs the gain will be little
the markdown link check fails due to:
in: There is a bad markdown link within the file referencing another. lifecycle-toolkit/.github/mlc_config.json Lines 2 to 9 in 2c51231
|
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Simon Schrottner <simon.schrottner@gmail.com> Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
Rebased and fixed issues, pr is green. Additional note regarding running changes only for the files changed. Especially a link checker is a good example for such a test because we also want to check the "incoming" links from other readmes. Detecting if an internal link changed, or a file is suddenly not available anymore etc. is not such a trivial topic. |
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: Meg McRoberts <mmcroberts@cloudbees.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-ups can be tackle in #1444
Replaces #1337, #1336, and other corrupted PRs.
Satisfies #1302
Getting started guide for the orchestrate pre/post-deployment checks use case, based on Andi's demo video
Comments welcome but this still needs some writing