fix(metrics-operator): introduce IsStatusSet method to KeptnMetric #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
SonarCloud Quality Gate failed.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 61.59% 59.58% -2.02%
==========================================
Files 137 112 -25
Lines 10471 9462 -1009
==========================================
- Hits 6450 5638 -812
+ Misses 3768 3613 -155
+ Partials 253 211 -42 see 25 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
approved these changes
May 17, 2023
bacherfl
approved these changes
May 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduced method was removed by this PR 3c465d0#diff-62dbadcf91fc4f2b7cb287a2251c530635223016577a548b21fcf6eda8291137L134
but it's used by the klt-operator here https://github.com/keptn/lifecycle-toolkit/blob/main/operator/controllers/common/providers/keptnmetric/keptnmetric.go#L27