Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Decoder Injector interface from webhook #1445

Closed
Tracked by #1448
RealAnna opened this issue May 22, 2023 · 1 comment · Fixed by #1563 or #1701
Closed
Tracked by #1448

Remove Decoder Injector interface from webhook #1445

RealAnna opened this issue May 22, 2023 · 1 comment · Fixed by #1563 or #1701
Assignees
@geoffrey1330
Labels
chore Maintenance good first issue Good for newcomers
Milestone
0.8.3

Comments

@RealAnna
Copy link
Contributor

RealAnna commented May 22, 2023 •
edited
Loading

Unfortunately, controller runtime from version 0.15.0 onward does not support the injection of decoders anymore. So to prevent future failures we do need to change our lifecycle operator main to explicitly initialize the decoders. This has been already tested here: https://github.com/keptn/lifecycle-toolkit/blob/poc/scheduling_gates/operator/main.go#L351
@RealAnna RealAnna added chore Maintenance operator labels May 22, 2023
@RealAnna RealAnna mentioned this issue May 22, 2023
Closed
This was referenced May 22, 2023
Closed
Closed
@thisthat thisthat added the status: ready-for-refinement Issue is relevant for the next backlog refinment label May 25, 2023
@thisthat thisthat added this to the 0.9 milestone May 31, 2023
@thisthat thisthat added good first issue Good for newcomers and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Jun 13, 2023
@geoffrey1330
Copy link
Member

Hi @thisthat I want to contribute to this. could you please assign it to me.

@geoffrey1330 geoffrey1330 mentioned this issue Jun 14, 2023
Merged
@geoffrey1330 geoffrey1330 mentioned this issue Jun 22, 2023
Closed
7 tasks
@RealAnna RealAnna mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrey1330 geoffrey1330

Labels
chore Maintenance good first issue Good for newcomers
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.8.3
3 participants
@thisthat @geoffrey1330 @RealAnna