feat: add support for timeframe in `KeptnMetric` #1471

rakshitgondwal · 2023-05-25T13:46:08Z

Fixes #981

Changes made:

Added range.interval field in KeptnMetric.
Set the default value of range.interval to 5m.
Added a validating webhook to check if range.interval can be parsed by https://pkg.go.dev/time#ParseDuration.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

netlify · 2023-05-25T13:46:39Z

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name	Link
🔨 Latest commit	`661e0db`
🔍 Latest deploy log	https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6492dcfeef5a440007283134
😎 Deploy Preview	https://deploy-preview-1471--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2023-05-25T13:48:36Z

Codecov Report

Merging #1471 (2beea9c) into main (b37aed9) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   63.17%   63.38%   +0.20%     
==========================================
  Files         142      142              
  Lines       10784    10822      +38     
==========================================
+ Hits         6813     6859      +46     
+ Misses       3713     3707       -6     
+ Partials      258      256       -2

Impacted Files	Coverage Δ
metrics-operator/api/v1alpha3/keptnmetric_types.go	`100.00% <ø> (ø)`
...trics-operator/api/v1alpha3/keptnmetric_webhook.go	`90.47% <100.00%> (+90.47%)`	⬆️

... and 5 files with indirect coverage changes

Flag	Coverage Δ
certificate-operator	`68.55% <ø> (ø)`
component-tests	`60.37% <ø> (+1.88%)`	⬆️
lifecycle-operator	`84.48% <ø> (ø)`
metrics-operator	`82.31% <100.00%> (+0.65%)`	⬆️
scheduler	`30.45% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

metrics-operator/config/webhook/manifests.yaml

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

metrics-operator/api/v1alpha3/keptnmetric_types.go

metrics-operator/api/v1alpha3/keptnmetric_webhook.go

metrics-operator/api/v1alpha3/keptnmetric_webhook_test.go

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

metrics-operator/config/certmanager/certificate.yaml

metrics-operator/api/v1alpha3/keptnmetric_types.go

metrics-operator/config/default/webhookcainjection_patch.yaml

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

metrics-operator/api/v1alpha3/keptnmetric_webhook.go

test/integration/metrics/goodmetric1.yaml

metrics-operator/api/v1alpha3/keptnmetric_webhook_test.go

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

odubajDT · 2023-06-14T13:19:58Z

Let's merge this PR after the 0.8.0 release

thisthat · 2023-06-21T08:01:14Z

We released KLT v0.8.0 so we can go ahead and merge this PR :) please @rakshitgondwal resolve the conflicts :)

Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

sonarcloud · 2023-06-21T14:01:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

odubajDT · 2023-06-22T05:29:10Z

Hello @rakshitgondwal, thank you for your contribution! :)

rakshitgondwal · 2023-06-22T06:01:42Z

Thanks a lot for the constant help! Really happy to get this feature merged.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com> Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Nitishupkr <nitishupkr@gmail.com>

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com> Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>

feat: add range.interval and validating webhook

d8f9370

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

github-actions bot added the metrics-operator label May 25, 2023

rakshitgondwal added 2 commits May 26, 2023 20:41

add manifests.yaml for webhook

bcc54a2

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

update admissionReviewVersion

5d57409

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

bacherfl reviewed May 30, 2023

View reviewed changes

metrics-operator/config/webhook/manifests.yaml Outdated Show resolved Hide resolved

bacherfl reviewed May 30, 2023

View reviewed changes

metrics-operator/config/webhook/manifests.yaml Show resolved Hide resolved

rakshitgondwal added 3 commits May 30, 2023 15:57

fix after review

16cd62c

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

minor change

2c71934

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

fix yamllint errors

f65d29f

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

thisthat reviewed May 30, 2023

View reviewed changes

metrics-operator/api/v1alpha3/keptnmetric_types.go Show resolved Hide resolved

Merge branch 'keptn:main' into feat/range-interval

35a3138

rakshitgondwal marked this pull request as ready for review May 31, 2023 12:37

rakshitgondwal requested a review from a team as a code owner May 31, 2023 12:37

thisthat reviewed May 31, 2023

View reviewed changes

metrics-operator/api/v1alpha3/keptnmetric_webhook.go Outdated Show resolved Hide resolved

metrics-operator/api/v1alpha3/keptnmetric_webhook.go Outdated Show resolved Hide resolved

metrics-operator/api/v1alpha3/keptnmetric_webhook_test.go Outdated Show resolved Hide resolved

rakshitgondwal added 2 commits May 31, 2023 22:32

fix after review

b09e2f2

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

update api version for load test

074eaef

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

bacherfl reviewed Jun 1, 2023

View reviewed changes

metrics-operator/config/certmanager/certificate.yaml Outdated Show resolved Hide resolved

bacherfl reviewed Jun 1, 2023

View reviewed changes

metrics-operator/api/v1alpha3/keptnmetric_types.go Show resolved Hide resolved

bacherfl reviewed Jun 1, 2023

View reviewed changes

metrics-operator/config/default/webhookcainjection_patch.yaml Outdated Show resolved Hide resolved

rakshitgondwal added 2 commits June 1, 2023 17:23

fix after review

bc176af

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

fix validate helm chart err

5b56c00

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

rakshitgondwal requested review from thisthat and bacherfl June 1, 2023 12:20

bacherfl reviewed Jun 1, 2023

View reviewed changes

metrics-operator/api/v1alpha3/keptnmetric_webhook.go Outdated Show resolved Hide resolved

bacherfl reviewed Jun 1, 2023

View reviewed changes

test/integration/metrics/goodmetric1.yaml Show resolved Hide resolved

bacherfl reviewed Jun 1, 2023

View reviewed changes

metrics-operator/api/v1alpha3/keptnmetric_webhook_test.go Show resolved Hide resolved

rakshitgondwal and others added 2 commits June 1, 2023 21:28

add more tests

9272396

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

Merge branch 'main' into feat/range-interval

93037d3

Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

rakshitgondwal dismissed bacherfl’s stale review via 7268581 June 7, 2023 14:02

Merge branch 'keptn:main' into feat/range-interval

49a0e20

rakshitgondwal requested review from odubajDT and bacherfl June 12, 2023 16:46

bacherfl previously approved these changes Jun 13, 2023

View reviewed changes

odubajDT previously approved these changes Jun 14, 2023

View reviewed changes

odubajDT added the on hold Do not merge yet label Jun 14, 2023

Merge branch 'keptn:main' into feat/range-interval

cf44799

rakshitgondwal mentioned this pull request Jun 20, 2023

feat: update Prometheus API to query metrics over a range #1587

Merged

thisthat removed the on hold Do not merge yet label Jun 21, 2023

Merge branch 'main' into feat/range-interval

661e0db

Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

rakshitgondwal dismissed stale reviews from odubajDT and bacherfl via 661e0db June 21, 2023 11:20

fix helm-generation check err

2beea9c

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>

github-actions bot added the helm label Jun 21, 2023

bacherfl approved these changes Jun 22, 2023

View reviewed changes

odubajDT approved these changes Jun 22, 2023

View reviewed changes

odubajDT merged commit 4d9ceb7 into keptn:main Jun 22, 2023
38 checks passed

keptn-bot mentioned this pull request Jun 22, 2023

chore: release 0.8.1 #1610

Closed

keptn-bot mentioned this pull request Jun 26, 2023

chore: release klt 0.8.1 #1620

Merged

This was referenced Jul 5, 2023

Introduce interval field for kubectl get KeptnMetric #1677

Closed

Document timeframe feature for KeptnMetric #1702

Closed

rakshitgondwal mentioned this pull request Jul 18, 2023

Aggregation Functions for KeptnMetric #1731

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for timeframe in `KeptnMetric` #1471

feat: add support for timeframe in `KeptnMetric` #1471

rakshitgondwal commented May 25, 2023

netlify bot commented May 25, 2023 •

edited

Loading

codecov bot commented May 25, 2023 •

edited

Loading

odubajDT commented Jun 14, 2023

thisthat commented Jun 21, 2023 •

edited

Loading

sonarcloud bot commented Jun 21, 2023

odubajDT commented Jun 22, 2023

rakshitgondwal commented Jun 22, 2023

feat: add support for timeframe in KeptnMetric #1471

feat: add support for timeframe in KeptnMetric #1471

Conversation

rakshitgondwal commented May 25, 2023

netlify bot commented May 25, 2023 • edited Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

codecov bot commented May 25, 2023 • edited Loading

Codecov Report

odubajDT commented Jun 14, 2023

thisthat commented Jun 21, 2023 • edited Loading

sonarcloud bot commented Jun 21, 2023

odubajDT commented Jun 22, 2023

rakshitgondwal commented Jun 22, 2023

feat: add support for timeframe in `KeptnMetric` #1471

feat: add support for timeframe in `KeptnMetric` #1471

netlify bot commented May 25, 2023 •

edited

Loading

codecov bot commented May 25, 2023 •

edited

Loading

thisthat commented Jun 21, 2023 •

edited

Loading