Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor contributing guide - source file structure #1523

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

YashPimple
Copy link
Member

@YashPimple YashPimple commented Jun 5, 2023

Relate #972
Fixes #998

cc @StackScribe
Signed-off-by: Yash Pimple yashpimple22@gmai.com

Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
@YashPimple YashPimple requested review from a team as code owners June 5, 2023 11:23
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 5, 2023
@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 4fd78a4
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/648710025c02130008bac113
😎 Deploy Preview https://deploy-preview-1523--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

StackScribe
StackScribe previously approved these changes Jun 8, 2023
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be updated to reflect the KLT docs structure a little better but let's get this merged and then address those changes in a separate PR.

@mowies mowies changed the title docs: update docs source structure docs: refactor contributing guide Jun 12, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@mowies mowies changed the title docs: refactor contributing guide docs: refactor contributing guide - source file structure Jun 12, 2023
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@StackScribe StackScribe merged commit c97b4b9 into keptn:main Jun 12, 2023
17 checks passed
@keptn-bot keptn-bot mentioned this pull request Jun 12, 2023
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 19, 2023
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: Meg McRoberts <DreidelLhasa@yahoo.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrib: doc source structure
3 participants