feat: cert-manager monorepo setup #1528

mowies · 2023-06-07T08:20:04Z

This PR

sets up release please to work with the KLT repo as a monorepo with separate releases for KLT and KLT cert-manager
Separate release PRs will be created for the 2 artifacts that can be merged separately. Release Please will create separate git tags and github releases for 2 artifacts as well

netlify · 2023-06-07T08:20:29Z

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name	Link
🔨 Latest commit	`7d7eb00`
🔍 Latest deploy log	https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6492ef99f5fed90008273732
😎 Deploy Preview	https://deploy-preview-1528--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2023-06-07T08:23:26Z

Codecov Report

Merging #1528 (a91f094) into main (b37aed9) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   63.17%   63.20%   +0.02%     
==========================================
  Files         142      142              
  Lines       10784    10784              
==========================================
+ Hits         6813     6816       +3     
+ Misses       3713     3711       -2     
+ Partials      258      257       -1

see 1 file with indirect coverage changes

Flag	Coverage Δ
certificate-operator	`68.55% <ø> (ø)`
component-tests	`58.49% <ø> (ø)`
lifecycle-operator	`84.48% <ø> (ø)`
metrics-operator	`81.66% <ø> (ø)`
scheduler	`30.45% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

.github/workflows/release.yml

.markdownlint-cli2.yaml

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix cosign repo url Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> revert readme changes Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add meaningful release debug info Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> exchange token Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> exchange token Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> revert more debugging things Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> revert debugging and trial changes Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: add cert manager changelog to MD lint ignores Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat: some random other feature Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat: some random newlines Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: release cert-manager 0.7.4 (#110) Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat: remove wrong changelog file Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat: fix image tag clean up for cert manager Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: release cert-manager 0.7.3 (#107) Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: release klt 0.7.3 (#108) Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat: a change for both monorepo artifacts Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> clean up image tags, better build tools caching Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: release klt 0.7.2 (#106) Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: release cert-manager 0.7.2 (#105) Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove trailing whitespace from pipeline Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove trailing whitespace from pipeline Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> make sure nothing gets pushed to keptn Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> first try with full setup Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix braces Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> try dynamic build matrix Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> add back cosign step Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix labels in dockerfiles Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> rest outputs Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> monorepo setup: change cert manager changelog path Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> monorepo setup: change last commit sha to reduce changelog Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> chore: monorepo setup adjust rp config Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat(functions-runtime): some random change in the functions runtime Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> feat(cert-manager): some random change in cert manager Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> monorepo setup: add last commit sha to reduce changelog Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> monorepo setup: add changes from poc Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

sonarcloud · 2023-06-21T12:47:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

.github/workflows/release.yml

thisthat

Great work 👍

release-please-config.json

bacherfl

Left one question, but approving in the meantime as this question is just to fill out my knowledge gap about release please :)

mowies · 2023-06-26T09:31:46Z

for future reference: the release version of a single component can be adjusted by adding the Release-As: X.X.X annotation to the commit body of a commit that only changes something in the component where you want to adjust the version.

CC: @thisthat

sumeet-zuora · 2023-06-28T14:24:20Z

Can we also add an option of hostNetwork for deployments in Helm Charts .. this is w.r.t https://keptn.slack.com/archives/CNRCGFU3U/p1686915988851709

mowies · 2023-06-28T14:53:34Z

let's please continue the discussion in the issue you created :)
#1570

if that is not enough please create a separate issue for your request

github-actions bot added cert-manager documentation Improvements or additions to documentation helm metrics-operator operator ops scheduler labels Jun 7, 2023

github-actions bot removed operator scheduler metrics-operator labels Jun 7, 2023

mowies force-pushed the cert-manager-monorepo-support branch 2 times, most recently from 77abea8 to 864bee3 Compare June 7, 2023 13:15

github-actions bot removed helm documentation Improvements or additions to documentation labels Jun 7, 2023

mowies commented Jun 7, 2023

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

.markdownlint-cli2.yaml Show resolved Hide resolved

This was referenced Jun 20, 2023

[Tracking] Transform KLT into a monorepo #1588

Closed

Monorepo setup for metrics-operator #1597

Closed

Monorepo setup for lifecycle operator #1598

Closed

mowies force-pushed the cert-manager-monorepo-support branch from 7713050 to 7d7eb00 Compare June 21, 2023 12:39

set klt version correctly

a91f094

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

github-actions bot added the helm label Jun 21, 2023

mowies marked this pull request as ready for review June 21, 2023 13:16

mowies requested a review from a team as a code owner June 21, 2023 13:16

thisthat reviewed Jun 26, 2023

View reviewed changes

.github/workflows/release.yml Show resolved Hide resolved

thisthat approved these changes Jun 26, 2023

View reviewed changes

bacherfl reviewed Jun 26, 2023

View reviewed changes

release-please-config.json Show resolved Hide resolved

bacherfl approved these changes Jun 26, 2023

View reviewed changes

mowies merged commit 0156f15 into keptn:main Jun 26, 2023
34 checks passed

mowies deleted the cert-manager-monorepo-support branch June 26, 2023 08:43

This was referenced Jun 26, 2023

chore: release cert-manager 1.0.0 #1619

Merged

chore: release klt 0.8.1 #1620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cert-manager monorepo setup #1528

feat: cert-manager monorepo setup #1528

mowies commented Jun 7, 2023 •

edited

Loading

netlify bot commented Jun 7, 2023 •

edited

Loading

codecov bot commented Jun 7, 2023 •

edited

Loading

sonarcloud bot commented Jun 21, 2023

thisthat left a comment

bacherfl left a comment

mowies commented Jun 26, 2023

sumeet-zuora commented Jun 28, 2023

mowies commented Jun 28, 2023

feat: cert-manager monorepo setup #1528

feat: cert-manager monorepo setup #1528

Conversation

mowies commented Jun 7, 2023 • edited Loading

This PR

netlify bot commented Jun 7, 2023 • edited Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

codecov bot commented Jun 7, 2023 • edited Loading

Codecov Report

sonarcloud bot commented Jun 21, 2023

thisthat left a comment

Choose a reason for hiding this comment

bacherfl left a comment

Choose a reason for hiding this comment

mowies commented Jun 26, 2023

sumeet-zuora commented Jun 28, 2023

mowies commented Jun 28, 2023

mowies commented Jun 7, 2023 •

edited

Loading

netlify bot commented Jun 7, 2023 •

edited

Loading

codecov bot commented Jun 7, 2023 •

edited

Loading