Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix </details> ending under watch pods in _index.md #1636

Merged
merged 2 commits into from
Jun 28, 2023
Merged

docs: fix </details> ending under watch pods in _index.md #1636

merged 2 commits into from
Jun 28, 2023

Conversation

staceypotter
Copy link
Contributor

fixed an issue with collapsible caret/arrow ending page text was hiding under "watch pods" section

@staceypotter
docs: fix </details> ending under watch pods in _index.md
abddd78 
fixed an issue with collapsible caret/arrow ending page text was hiding under "watch pods" section

Signed-off-by: Stacey Potter <50154848+staceypotter@users.noreply.github.com>
@staceypotter staceypotter requested review from a team as code owners June 27, 2023 23:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 27, 2023
@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 7282eaa
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/649bdc750943bf000787c7d7
😎 Deploy Preview https://deploy-preview-1636--keptn-lifecycle-toolkit.netlify.app/docs/getting-started/generic-gs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agardnerIT
Copy link
Contributor

This is a repeat PR of #1633 that was merged into page. It was merged into page because clicking the "view page source" from the website took us to page and thus Stacey (logically and correctly) followed the suggested path. Perhaps the "view page source" button links to the wrong branch and it should instead suggest all edits on main?

mowies
mowies previously approved these changes Jun 28, 2023
View reviewed changes
@mowies
Update docs/content/en/docs/getting-started/generic-gs/_index.md
7282eaa 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies merged commit 7274cf7 into keptn:main Jun 28, 2023
17 checks passed
@keptn-bot keptn-bot mentioned this pull request Jun 28, 2023
Merged
@staceypotter staceypotter deleted the patch-1 branch June 28, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@mowies mowies mowies approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@staceypotter @agardnerIT @thisthat @mowies @odubajDT