Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move Dora metrics info to "Implementing" section #1639

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

StackScribe
Copy link
Contributor

Our documentation has no mention of running DORA metrics except for what is in the observability Getting Started Guide. This PR copies that information into a page in the "Implementing" section so we can link to it for migration and other places in the documentation.

Text is mostly unmodified. I did add a couple links and replaced "annotate Deployment resources" with "annotate Workloads" and a list of the resources that are considered to be Workloads.

Also modified the weight of the "Keptn Metrics" page so that this section begins with Integrate, DORA metrics, Keptn metrics. Need to adjust the order of some other sections but will do that in a separate PR.

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jun 28, 2023
@StackScribe StackScribe added this to the 0.9 milestone Jun 28, 2023
@StackScribe StackScribe self-assigned this Jun 28, 2023
@StackScribe StackScribe requested review from a team as code owners June 28, 2023 04:52
@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c3eb02d
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a511aaf1b15e0008ffdcba
😎 Deploy Preview https://deploy-preview-1639--keptn-lifecycle-toolkit.netlify.app/docs/getting-started/observability
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mowies
Copy link
Member

mowies commented Jun 28, 2023

This PR copies that information into a page in the "Implementing" section so we can link to it for migration and other places in the documentation.

Copies it from where? 🤔

@StackScribe
Copy link
Contributor Author

This PR copies that information into a page in the "Implementing" section so we can link to it for migration and other places in the documentation.

Copies it from where? 🤔

First line of the PR description -- it comes from the Observability Getting Started Guide

Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@mowies
Copy link
Member

mowies commented Jun 28, 2023

@StackScribe if the info was in a previous file already, why not delete it in the original file? Do we need the duplicate content?

Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
odubajDT
odubajDT previously approved these changes Jun 28, 2023
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: Meg McRoberts meg.mcroberts@dynatrace.com

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies changed the title docs: add Dora metrics info to "Implementing" section docs: move Dora metrics info to "Implementing" section Jul 5, 2023
@mowies mowies merged commit 55ee941 into keptn:main Jul 5, 2023
18 checks passed
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants