docs: fix installation steps in E2E example

[odubajDT]

Fixes: #1640

[netlify]

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name	Link
🔨 Latest commit	f68857e
🔍 Latest deploy log	https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/649c1083815ce40008f7611d
😎 Deploy Preview	https://deploy-preview-1645--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[StackScribe]

Could you explain a bit more about what the issue is here? Are the scripts other than make install broken?

I confess that I am troubled by this Getting Started guide. Having the scripts that set everything up is handy for a demo but seem inadequate for a Getting Started Guide since the user does not learn how to do the set up. This is, of course, outside the scope of this PR, but just saying ;-)

[agardnerIT]

This PR looks good. None of the following comment should be seen as a blocker for getting this PR merged. But I agree with @StackScribe. A magic make command really doesn't help a new user understand anything about what's going on. We may as well provide a killercoda, pre-installed VM.

On a different note, there's this comment: "Note To export traces to the OpenTelemetry Collector, you need a KeptnConfig CRD with spec.OTelCollectorUrl specified in the namespace where KLT is installed."

The comment is ambiguous though as to whether or not the make install command will do that for us in the demo or we're left to add that in if we require it.

Since the emission of OTEL metrics is a core use case, should we build OTEL emission and a collector into the demo?

[odubajDT]

Hey @agardnerIT @StackScribe . Thank you for your comments, totally agree! We should maybe work on a more specific explanation what is actually hidden behind make install. The aim of this PR was just to fix a small bug in the documentation (#1640). The previous version actually didn't work, as it did not install the KLT as part of make install-observability, so the excercise didn't work fully. We can maybe follow-up with a specific explanation in another PR? WDYT?

Thanks!