Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): parse flags so they can be configured #1649

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jun 30, 2023

Closes #1648

Manually tested this by setting the --metrics-bind-address of the lifecycle operator to 127.0.0.1:8087, which resulted in the following log during the operator startup:

2023-07-03T05:53:24Z	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": "127.0.0.1:8087"}

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 24c93cd
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/649e8a1eac1e870008924856
😎 Deploy Preview https://deploy-preview-1649--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1649 (f95fe2c) into main (791e211) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
+ Coverage   63.48%   63.51%   +0.02%     
==========================================
  Files         142      142              
  Lines       10892    10892              
==========================================
+ Hits         6915     6918       +3     
+ Misses       3716     3714       -2     
+ Partials      261      260       -1     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.16% <ø> (-0.34%) ⬇️
lifecycle-operator 84.48% <ø> (ø)
metrics-operator 82.26% <ø> (ø)
scheduler 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review July 3, 2023 05:56
@bacherfl bacherfl requested a review from a team as a code owner July 3, 2023 05:56
@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 4243085 into keptn:main Jul 3, 2023
38 checks passed
@bacherfl bacherfl deleted the fix/1648/cli-args branch July 3, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command line flags are not respected
3 participants