feat: update Dynatrace provider to query metrics over a range #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
- Coverage 63.54% 63.48% -0.06%
==========================================
Files 143 143
Lines 10909 10913 +4
==========================================
- Hits 6932 6928 -4
- Misses 3716 3722 +6
- Partials 261 263 +2
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
reviewed
Jul 5, 2023
metrics-operator/controllers/common/providers/dynatrace/dynatrace.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
reviewed
Jul 6, 2023
metrics-operator/controllers/common/providers/dynatrace/dynatrace.go
Outdated
Show resolved
Hide resolved
…ace.go Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
thisthat
reviewed
Jul 7, 2023
metrics-operator/controllers/common/providers/dynatrace/dynatrace.go
Outdated
Show resolved
Hide resolved
metrics-operator/controllers/common/providers/dynatrace/dynatrace_test.go
Outdated
Show resolved
Hide resolved
metrics-operator/controllers/common/providers/dynatrace/dynatrace_test.go
Outdated
Show resolved
Hide resolved
thisthat
reviewed
Jul 7, 2023
metrics-operator/controllers/common/providers/dynatrace/dynatrace_test.go
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
thisthat
approved these changes
Jul 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Jul 18, 2023
bacherfl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1012
Changes made: