Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): avoid multiple creations of the same KeptnTask #1676

Merged
merged 14 commits into from
Jul 6, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jul 5, 2023

Closes #1675

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit ff66437
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a54cd6e2a600000726f3f5
😎 Deploy Preview https://deploy-preview-1676--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1676 (ec7f619) into main (5602bd1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   63.47%   63.47%   -0.01%     
==========================================
  Files         142      142              
  Lines       10897    10899       +2     
==========================================
+ Hits         6917     6918       +1     
- Misses       3718     3719       +1     
  Partials      262      262              
Impacted Files Coverage Δ
...ontrollers/lifecycle/keptnappversion/controller.go 78.19% <ø> (ø)
operator/controllers/common/taskhandler.go 79.13% <100.00%> (-0.43%) ⬇️
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.27% <ø> (ø)
lifecycle-operator 84.49% <100.00%> (+<0.01%) ⬆️
metrics-operator 82.26% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
This reverts commit 1706db0.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…eptnTask""

This reverts commit 47a529c.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl force-pushed the fix/1675/multiple-task-creations branch from daed4da to 83827aa Compare July 5, 2023 11:48
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review July 5, 2023 13:29
@bacherfl bacherfl requested a review from a team as a code owner July 5, 2023 13:29
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 78ba574 into keptn:main Jul 6, 2023
38 checks passed
@bacherfl bacherfl deleted the fix/1675/multiple-task-creations branch July 6, 2023 05:28
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
…1676)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug :: KeptnAppVersion/KeptnWorkloadInstance Controllers create multiple instances of a KeptnTask
3 participants