Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm-chart): propagate labels for validation webhook #1678

Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Jul 5, 2023

Fixes #1669

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@thisthat thisthat requested a review from a team as a code owner July 5, 2023 11:28
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 189fe1d
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a553ed9bdf79000856904c
😎 Deploy Preview https://deploy-preview-1678--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

RealAnna
RealAnna previously approved these changes Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1678 (8262403) into main (59db60f) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
+ Coverage   63.47%   63.50%   +0.03%     
==========================================
  Files         142      142              
  Lines       10898    10898              
==========================================
+ Hits         6917     6921       +4     
+ Misses       3719     3716       -3     
+ Partials      262      261       -1     

see 5 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.50% <ø> (+1.01%) ⬆️
lifecycle-operator 84.48% <ø> (ø)
metrics-operator 82.26% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
RealAnna
RealAnna previously approved these changes Jul 5, 2023
helm/chart/Chart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Giovanni Liva <giovanni.liva@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies changed the title fix: propagate labels for validation webhook fix(helm-chart): propagate labels for validation webhook Jul 5, 2023
@thisthat thisthat merged commit 5602bd1 into keptn:main Jul 5, 2023
35 checks passed
@thisthat thisthat deleted the fix/1669/missing-labels-validating-webhook branch July 5, 2023 12:49
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug :: Helm Chart doesn't provide the correct labels to the validation webhook
3 participants