Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python-runtime): install curl to execute scripts referenced via url #1681

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jul 5, 2023

The missing curl binary in the ython runtime image was preventing scripts referenced via url to be executed. This PR resolves that

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl requested a review from a team as a code owner July 5, 2023 12:37
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 3321f14
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a564265aa53c0008c6f672
😎 Deploy Preview https://deploy-preview-1681--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1681 (3321f14) into main (59db60f) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1681      +/-   ##
==========================================
- Coverage   63.47%   63.41%   -0.06%     
==========================================
  Files         142      142              
  Lines       10898    10907       +9     
==========================================
  Hits         6917     6917              
- Misses       3719     3728       +9     
  Partials      262      262              

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
lifecycle-operator 84.49% <ø> (+0.01%) ⬆️
metrics-operator 82.26% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl merged commit ac0d515 into keptn:main Jul 5, 2023
32 of 33 checks passed
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
…rl (keptn#1681)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nitishupkr <nitishupkr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants