Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document timeframe feature for KeptnMetric #1703

Merged

Conversation

rakshitgondwal
Copy link
Member

Fixes #1702

Updated https://main.lifecycle.keptn.sh/docs/yaml-crd-ref/metric/ to support the range.interval field.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal rakshitgondwal requested review from a team as code owners July 11, 2023 11:40
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 11, 2023
@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 0615afa
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64ae76a33e596c0008747765
😎 Deploy Preview https://deploy-preview-1703--keptn-lifecycle-toolkit.netlify.app/docs/yaml-crd-ref/metric
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
odubajDT
odubajDT previously approved these changes Jul 12, 2023
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rakshitgondwal thanks for adding docs! Could you also update the metrics examples availabels at metrics-operator/config/samples ?

https://github.com/rakshitgondwal/lifecycle-toolkit/blob/docs/1702/timeframe-for-keptnmetric/metrics-operator/config/samples

@rakshitgondwal
Copy link
Member Author

Sure will do, should I also make the changes to examples/support in this PR only or should I raise another one for that? Those changes would be 2-3 liners only.

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1703 (f3b9621) into main (342d9d1) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
+ Coverage   63.46%   63.55%   +0.09%     
==========================================
  Files         143      143              
  Lines       10908    10908              
==========================================
+ Hits         6923     6933      +10     
+ Misses       3722     3715       -7     
+ Partials      263      260       -3     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.13% <ø> (+0.67%) ⬆️
lifecycle-operator 84.52% <ø> (ø)
metrics-operator 82.26% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna
Copy link
Contributor

Sure will do, should I also make the changes to examples/support in this PR only or should I raise another one for that? Those changes would be 2-3 liners only.

@rakshitgondwal I think you could squeeze that change here as well yes! Thankyou 🚀

Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@thisthat thisthat merged commit 077f0d5 into keptn:main Jul 19, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document timeframe feature for KeptnMetric
4 participants