Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce step field for KeptnMetric #1735

Closed
Tracked by #1731
rakshitgondwal opened this issue Jul 19, 2023 · 0 comments · Fixed by #1755
Closed
Tracked by #1731

Introduce step field for KeptnMetric #1735

rakshitgondwal opened this issue Jul 19, 2023 · 0 comments · Fixed by #1755
Labels
enhancement New feature or request metrics-operator

Comments

@rakshitgondwal
Copy link
Member

rakshitgondwal commented Jul 19, 2023

Goal

To imply aggregation functions, we would need a spec.range.step field.
This field can be defined as the Query resolution step width in duration format.

spec:
  range:
    step: <duration in string>

We already have a validating webhook that checks if range.interval can be parsed by https://pkg.go.dev/time#ParseDuration.
Modify the webhook so that checks the same for range.step too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metrics-operator
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants