Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs/content/en/contribute/docs/local-building/index.md #1753

Merged
merged 5 commits into from
Jul 22, 2023
Merged

docs: update docs/content/en/contribute/docs/local-building/index.md #1753

merged 5 commits into from
Jul 22, 2023

Conversation

viktoriussuwandi
Copy link
Contributor

Hi agardnerIT,
just trying to fix issue #1743, please check it out

Signed-off-by: Viktorius Suwandi <viktorius.tori@gmail.com>
@viktoriussuwandi viktoriussuwandi requested review from a team as code owners July 20, 2023 09:42
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 20, 2023
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c5f69c2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64b9d3efd4023f0008ee3cf1
😎 Deploy Preview https://deploy-preview-1753--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes it. Thanks!

@agardnerIT agardnerIT changed the title Update docs/content/en/contribute/docs/local-building/index.md docs: update docs/content/en/contribute/docs/local-building/index.md Jul 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@viktoriussuwandi
Copy link
Contributor Author

Hi @agardnerIT @RealAnna ,
Is there anything else need to do to merge this PR ?
Please let me know

@agardnerIT agardnerIT merged commit 14494c5 into keptn:main Jul 22, 2023
17 checks passed
@viktoriussuwandi viktoriussuwandi deleted the issue#1743 branch July 22, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants