-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: keptn Scheduler architecture documentation #1777
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
Hi @YashPimple thankyou for your contribution! I added a few suggestions, the main changes needed regards the scheduling logic. The keptn scheduler implements a plugin of the default k8s scheduler, this means that it just adds our own custom logic to one step of the default scheduler logic where we wait for a specific evaluation CRD to be successful before binding pods to nodes. I would not specify in this document how all other parts work, since this would overwhelm the reader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented above
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start, Yash, but I think this includes a lot of information that is already present in the rest of the documentation and we don't want to be needlessly duplicating information -- it becomes a maintenance headache.
This should probably be a shorter piece that talks about how the scheduler works "under the hood", as it were. It can reference other parts of the docs that have details about the resources and some how-to instructions but should basically talk about how the scheduler processes what it finds.
Thanks for your feedback! Will keep it concise and focus on the scheduler's inner workings also avoid duplication . Looking forward to crafting a more streamlined and informative piece. |
Thank you @RealAnna for your valuable feedback! I will prioritize refining the scheduling logic for the keptn scheduler plugin, while also ensuring to maintain a clear and concise explanation👍🏻 |
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
Hey @YashPimple this is great 🚀 I left a few nitpicks on some things, but I think we can merge soon 😃 |
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, Yash!
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
Signed-off-by: Yash Pimple <yashpimple22@gmail.com>
@RealAnna @StackScribe I have resolved the changes as per suggested in the Scheduler docs. Do have a look 👍🏻 |
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/concepts/architecture/components/scheduler/_index.md
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Relate: #770
Fixes: #1682
signed-off-by: YashPimple yashpimple22@gmail.com