-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: metrics-operator monorepo setup #1791
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
+ Coverage 83.38% 83.44% +0.06%
==========================================
Files 132 132
Lines 8190 8210 +20
==========================================
+ Hits 6829 6851 +22
+ Misses 1107 1106 -1
+ Partials 254 253 -1 see 5 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
b706584
to
b971abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the KLT release config to lifecycle operator is not really accurate IMO.
lifecycle operator is just that folder but KLT is everything else in the repo and maybe also the umbrella chart in the future. So those will in the end be separate entries in the release-please-config.
Hmm yes you are right, it is just one part and KLT is the whole toolkit incl. metrics-operator, cert-manager etc. What naming would you then suggest? I do not see the problems around umbrella charts and you have definitely more insights there. The "lifecycle operator" monorepo should not include lifecycle-operator, scheduler, python-runtime and functions runtime, as that are the pieces that need to be installed to have the whole package working. |
you could just leave it as |
f236626
to
c4bc899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, as discussed let's wait for @mowies approval due to the renaming work that's currently going on
2717005
to
8c2a564
Compare
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
6fb1c91
to
7806c2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR
Fixes: #1597
Test
This could be test only on fork:
PRs creted: https://github.com/odubajDT/lifecycle-controller/pulls
release please run: https://github.com/odubajDT/lifecycle-controller/actions/runs/5691308796/job/15426250933