Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics-operator monorepo setup #1791

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jul 27, 2023

This PR

  • sets up release please to work with the KLT repo as a monorepo with separate releases for KLT lifecycle-operator, KLT cert-manager and KLT metrics-operator
  • Separate release PRs will be created for the 3 artifacts that can be merged separately. Release Please will create separate git tags and github releases for 3 artifacts as well
  • renamed general klt release to lifecycle-operator, as from now it's a monorepo itself
  • remove release-please tag for metrics-operator on helm docs auto updates
  • re-generate CRD documentation

Fixes: #1597

Test

This could be test only on fork:

PRs creted: https://github.com/odubajDT/lifecycle-controller/pulls
release please run: https://github.com/odubajDT/lifecycle-controller/actions/runs/5691308796/job/15426250933

@github-actions github-actions bot added documentation Improvements or additions to documentation ops metrics-operator helm labels Jul 27, 2023
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit a783ae3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64cb8bee22b16c0008424ec3
😎 Deploy Preview https://deploy-preview-1791--keptn-lifecycle-toolkit.netlify.app/docs/yaml-crd-ref/taskdefinition
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1791 (a783ae3) into main (f2d5bdd) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   83.38%   83.44%   +0.06%     
==========================================
  Files         132      132              
  Lines        8190     8210      +20     
==========================================
+ Hits         6829     6851      +22     
+ Misses       1107     1106       -1     
+ Partials      254      253       -1     

see 5 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.74% <ø> (-0.07%) ⬇️
lifecycle-operator 84.91% <ø> (ø)
metrics-operator 83.02% <ø> (+0.29%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the chore/1597/monorepo-metrics-operator branch 2 times, most recently from b706584 to b971abf Compare July 28, 2023 07:23
@odubajDT odubajDT marked this pull request as ready for review July 28, 2023 07:53
@odubajDT odubajDT requested review from a team as code owners July 28, 2023 07:53
@odubajDT odubajDT requested a review from RealAnna July 28, 2023 09:38
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the KLT release config to lifecycle operator is not really accurate IMO.
lifecycle operator is just that folder but KLT is everything else in the repo and maybe also the umbrella chart in the future. So those will in the end be separate entries in the release-please-config.

release-please-config.json Outdated Show resolved Hide resolved
@odubajDT
Copy link
Contributor Author

odubajDT commented Aug 2, 2023

Changing the KLT release config to lifecycle operator is not really accurate IMO. lifecycle operator is just that folder but KLT is everything else in the repo and maybe also the umbrella chart in the future. So those will in the end be separate entries in the release-please-config.

Hmm yes you are right, it is just one part and KLT is the whole toolkit incl. metrics-operator, cert-manager etc. What naming would you then suggest? I do not see the problems around umbrella charts and you have definitely more insights there. The "lifecycle operator" monorepo should not include lifecycle-operator, scheduler, python-runtime and functions runtime, as that are the pieces that need to be installed to have the whole package working.

@mowies
Copy link
Member

mowies commented Aug 2, 2023

you could just leave it as klt like it was before

@odubajDT odubajDT force-pushed the chore/1597/monorepo-metrics-operator branch from f236626 to c4bc899 Compare August 2, 2023 07:06
bacherfl
bacherfl previously approved these changes Aug 2, 2023
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as discussed let's wait for @mowies approval due to the renaming work that's currently going on

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT force-pushed the chore/1597/monorepo-metrics-operator branch from 6fb1c91 to 7806c2d Compare August 3, 2023 10:04
mowies
mowies previously approved these changes Aug 3, 2023
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 51445eb into main Aug 3, 2023
37 checks passed
@odubajDT odubajDT deleted the chore/1597/monorepo-metrics-operator branch August 3, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm metrics-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monorepo setup for metrics-operator
5 participants