feat: update prometheus api to support range.step
#1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
+ Coverage 83.37% 83.52% +0.15%
==========================================
Files 136 136
Lines 8348 8391 +43
==========================================
+ Hits 6960 7009 +49
+ Misses 1130 1126 -4
+ Partials 258 256 -2
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
reviewed
Aug 8, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
reviewed
Aug 10, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Aug 10, 2023
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
reviewed
Aug 10, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
bacherfl
previously approved these changes
Aug 10, 2023
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Aug 10, 2023
bacherfl
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1736
Changes made:
range.stepvalue.EvaluateQueryForStepfunc inprometheus.gothat returns a[]slicewith the result values inside it. Later, aggregation functions would be applied to the values inside this slice.resultSliceas a whole for therawValue.