feat: aggregation functions support for metrics controller #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
- Coverage 84.18% 84.06% -0.13%
==========================================
Files 150 150
Lines 9525 9581 +56
==========================================
+ Hits 8019 8054 +35
- Misses 1221 1239 +18
- Partials 285 288 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
reviewed
Aug 25, 2023
bacherfl
reviewed
Aug 25, 2023
bacherfl
reviewed
Aug 25, 2023
bacherfl
reviewed
Aug 25, 2023
bacherfl
reviewed
Aug 25, 2023
bacherfl
reviewed
Aug 25, 2023
thisthat
reviewed
Aug 25, 2023
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
bacherfl
previously approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM! Just tried out this new functionality on my cluster. To also reach the getStepQueryResults function in the unit tests, we will need to do some refactoring, but this will exceed the scope of this PR. I will create a follow up issue to tackle the refactoring
thisthat
previously approved these changes
Sep 4, 2023
Signed-off-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>
rakshitgondwal
dismissed stale reviews from thisthat and bacherfl
via
157be77
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Sep 6, 2023
odubajDT
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1737
Changes made: