chore: add status field docs to all CRDs #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1807 +/- ##
==========================================
- Coverage 63.57% 61.61% -1.96%
==========================================
Files 143 118 -25
Lines 10937 9713 -1224
==========================================
- Hits 6953 5985 -968
+ Misses 3722 3512 -210
+ Partials 262 216 -46
... and 25 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
changed the title
mowies
previously approved these changes
Jul 31, 2023
I am testing this, it seems like the crds are not updated by helm upgrade :( |
RealAnna
commented
Aug 1, 2023
mowies
reviewed
Aug 1, 2023
metrics-operator/config/crd/bases/metrics.keptn.sh_keptnmetricsproviders.yaml
Show resolved
Hide resolved
RealAnna
force-pushed
the
chore/add_status_to_crd_docs
branch
from
d82281f
to
7d89716
Compare
mowies
reviewed
Aug 1, 2023
.github/scripts/generate-crd-docs/crd-docs-generator-config.yaml
Outdated
Show resolved
Hide resolved
mowies
previously approved these changes
Aug 2, 2023
|
Looks good :) but we can have an |
bacherfl
reviewed
Aug 2, 2023
odubajDT
previously approved these changes
Aug 2, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
chore/add_status_to_crd_docs
branch
2 times, most recently
from
76f8062
to
47b3d9a
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com> fix: persist-credentials: false Signed-off-by: realanna <anna.reale@dynatrace.com> test Signed-off-by: realanna <anna.reale@dynatrace.com> fix: review Signed-off-by: realanna <anna.reale@dynatrace.com> fix: review Signed-off-by: realanna <anna.reale@dynatrace.com> fix: review Signed-off-by: realanna <anna.reale@dynatrace.com> fix: review Signed-off-by: realanna <anna.reale@dynatrace.com> Update .github/scripts/generate-crd-docs/crd-docs-generator-config.yaml Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> fix crd docs generation by introducing dummy change Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix: regenerate manifests Signed-off-by: realanna <anna.reale@dynatrace.com> fix: regenerate manifests Signed-off-by: realanna <anna.reale@dynatrace.com> fix: regenerate manifests Signed-off-by: realanna <anna.reale@dynatrace.com> fix: regenerate manifests Signed-off-by: realanna <anna.reale@dynatrace.com> fix: add custom empty status Signed-off-by: realanna <anna.reale@dynatrace.com> fix: add custom empty status Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
chore/add_status_to_crd_docs
branch
from
7c00c4e
to
446ff36
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Aug 2, 2023
prakrit55
pushed a commit
to prakrit55/lifecycle-toolkit
that referenced
this pull request
Aug 3, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com> Signed-off-by: Griffin <prakritimandal611@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds status information to all CRDs where KLT sets the field.