Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): add Analysis CRD #1839

Merged
merged 4 commits into from
Aug 9, 2023
Merged

feat(metrics-operator): add Analysis CRD #1839

merged 4 commits into from
Aug 9, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Aug 4, 2023

fixes #1768

@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator labels Aug 4, 2023
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 793769b
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d25079496fab0008d77ec6
😎 Deploy Preview https://deploy-preview-1839--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1839 (799fc61) into main (adf4621) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1839   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files         134      135    +1     
  Lines        8288     8290    +2     
=======================================
+ Hits         6911     6913    +2     
  Misses       1121     1121           
  Partials      256      256           
Files Changed Coverage Δ
...-operator/apis/lifecycle/v1alpha1/common/phases.go 100.00% <ø> (ø)
metrics-operator/api/v1alpha3/analysis_types.go 100.00% <100.00%> (ø)
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.13% <ø> (ø)
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 82.92% <100.00%> (+0.02%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the ops label Aug 4, 2023
@RealAnna RealAnna marked this pull request as ready for review August 4, 2023 09:41
@RealAnna RealAnna requested review from a team as code owners August 4, 2023 09:41
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@bacherfl bacherfl changed the title feat(metrics-operator): add analysis CRD feat(metrics-operator): add Analysis CRD Aug 7, 2023
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the requested changes

@RealAnna RealAnna dismissed odubajDT’s stale review August 8, 2023 08:39

I do not want merge conflicts

mowies
mowies previously approved these changes Aug 8, 2023
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the requested changes

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix ref

Signed-off-by: realanna <anna.reale@dynatrace.com>

Update lifecycle-operator/apis/lifecycle/v1alpha1/common/phases.go

Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

feat(metrics-operator): make Ondrej happy

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): sample times

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): sample times

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): sample times

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): sample times

Signed-off-by: realanna <anna.reale@dynatrace.com>

Update lifecycle-operator/apis/lifecycle/v1alpha1/common/phases.go

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

feat(metrics-operator): integrwtion test

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix ref to Def

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix review

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix review

Signed-off-by: realanna <anna.reale@dynatrace.com>

Update docs/content/en/docs/crd-ref/metrics/v1alpha3/_index.md

Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/config/crd/bases/metrics.keptn.sh_analyses.yaml

Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update docs/content/en/docs/crd-ref/metrics/v1alpha3/_index.md

Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update docs/content/en/docs/crd-ref/metrics/v1alpha3/_index.md

Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

Update metrics-operator/api/v1alpha3/analysis_types.go

Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>

feat(metrics-operator): fix error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix error

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): regenerate crd md files

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): regenerate crd md files

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): remove wrong makefi;le change

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): review

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): review

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix lint

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): fix failing pipelines

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): add integration test

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): add example analysis CRD

Signed-off-by: realanna <anna.reale@dynatrace.com>

feat(metrics-operator): add analysis CRD

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
@github-actions github-actions bot removed the ops label Aug 8, 2023
bacherfl
bacherfl previously approved these changes Aug 9, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 9521a16 into main Aug 9, 2023
41 checks passed
@RealAnna RealAnna deleted the feat/1768/analysys branch August 9, 2023 09:24
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Aug 9, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm lifecycle-operator metrics-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap Analysis CRD
6 participants