-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-operator): update datadog api to support range.step
#1842
feat(metrics-operator): update datadog api to support range.step
#1842
Conversation
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1842 +/- ##
==========================================
+ Coverage 83.84% 83.96% +0.11%
==========================================
Files 141 141
Lines 8588 8641 +53
==========================================
+ Hits 7201 7255 +54
+ Misses 1130 1128 -2
- Partials 257 258 +1
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
range.step
range.step
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
metrics-operator/controllers/common/providers/datadog/datadog.go
Outdated
Show resolved
Hide resolved
metrics-operator/controllers/common/providers/datadog/datadog.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
metrics-operator/controllers/common/providers/datadog/datadog.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
metrics-operator/controllers/common/providers/datadog/datadog_test.go
Outdated
Show resolved
Hide resolved
metrics-operator/controllers/common/providers/datadog/datadog_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, LGTM! I left two optional suggestions regarding the unit tests, but all in all this looks good
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
Relates to #1736
Changes made:
range.step
value.