Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics-operator): make Fail target in AnalysisDefinition optional #1903

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix(metrics-operator): make Fail target in AnalysisDefinition optional #1903

merged 1 commit into from
Aug 21, 2023

Conversation

odubajDT
Copy link
Contributor

No description provided.

…onal

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit b10a803
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e323049267c80008f00a46
😎 Deploy Preview https://deploy-preview-1903--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1903 (b10a803) into main (06defd3) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1903      +/-   ##
==========================================
- Coverage   83.65%   83.54%   -0.12%     
==========================================
  Files         136      136              
  Lines        8427     8424       -3     
==========================================
- Hits         7050     7038      -12     
- Misses       1123     1129       +6     
- Partials      254      257       +3     
Files Changed Coverage Δ
...perator/api/v1alpha3/analysisdefinition_webhook.go 79.41% <ø> (-0.87%) ⬇️

... and 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.07% <ø> (-0.07%) ⬇️
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 83.59% <ø> (-0.04%) ⬇️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review August 21, 2023 08:47
@odubajDT odubajDT requested a review from a team as a code owner August 21, 2023 08:47
@thisthat thisthat changed the title fix(metrics-operator): make Failure target in AnalysisDefinition optional fix(metrics-operator): make Fail target in AnalysisDefinition optional Aug 21, 2023
@odubajDT odubajDT merged commit df874e2 into keptn:main Aug 21, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants