Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove generation of KLT manifest releases #1942

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 24, 2023

This PR

  • removes the generation of KLT manifest releases from the release pipeline

Notes

the manifests will still be released further downstream as part of the release of the KLT umbrella helm chart

Fixes #1602

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies requested review from a team as code owners August 24, 2023 07:46
@mowies mowies added the on hold Do not merge yet label Aug 24, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1942 (82bd1b7) into main (6da3276) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 82bd1b7 differs from pull request most recent head 61633d7. Consider uploading reports for the commit 61633d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1942      +/-   ##
==========================================
+ Coverage   84.36%   84.37%   +0.01%     
==========================================
  Files         150      150              
  Lines        9623     9623              
==========================================
+ Hits         8118     8119       +1     
+ Misses       1222     1221       -1     
  Partials      283      283              

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.34% <ø> (+0.27%) ⬆️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 87.15% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking 'till release

@RealAnna RealAnna removed the on hold Do not merge yet label Sep 19, 2023
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna RealAnna dismissed thisthat’s stale review September 19, 2023 12:24

released so we can now merge this

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 61633d7
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650993bc3e04040008374677
😎 Deploy Preview https://deploy-preview-1942--keptn-lifecycle-toolkit.netlify.app/docs/install/install
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

odubajDT
odubajDT previously approved these changes Sep 19, 2023
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit a73a1d0 into keptn:main Sep 19, 2023
9 checks passed
@mowies mowies deleted the drop-manifest-support branch September 26, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for manifest installation
5 participants