Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): clean up KeptnTask API by removing duplicated attributes #1965

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Aug 28, 2023

Closes #1946

…tion of information

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 185bc09
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64ec6657274739000745e542
😎 Deploy Preview https://deploy-preview-1965--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation helm lifecycle-operator labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1965 (54abff7) into main (6273709) will decrease coverage by 0.06%.
Report is 4 commits behind head on main.
The diff coverage is 94.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
- Coverage   84.00%   83.95%   -0.06%     
==========================================
  Files         142      143       +1     
  Lines        8817     8811       -6     
==========================================
- Hits         7407     7397      -10     
- Misses       1148     1151       +3     
- Partials      262      263       +1     
Files Changed Coverage Δ
...or/apis/lifecycle/v1alpha3/keptntask_conversion.go 0.00% <0.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 72.81% <ø> (-0.30%) ⬇️
...r/apis/lifecycle/v1alpha3/keptnappversion_types.go 97.68% <100.00%> (+0.04%) ⬆️
...perator/apis/lifecycle/v1alpha3/keptntask_types.go 97.59% <100.00%> (ø)
.../lifecycle/v1alpha3/keptnworkloadinstance_types.go 95.49% <100.00%> (+0.08%) ⬆️
...controllers/lifecycle/keptntask/runtime_builder.go 70.44% <100.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.89% <100.00%> (-0.04%) ⬇️
lifecycle-operator 84.94% <94.73%> (+0.01%) ⬆️
metrics-operator 85.57% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review August 28, 2023 13:31
@bacherfl bacherfl requested review from a team as code owners August 28, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm lifecycle-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeptnTask sample version and workload is wrong
3 participants