Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): introduce range operators in AnalysisDefinition #1976

Merged
merged 7 commits into from
Aug 30, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Aug 29, 2023

Changes

  • introduces inRange and notInRange operators in AnalysisDefinition
  • support these operators into analysis scoring logic
  • unit tests

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 0605ae9
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64ef02d1922c990008a72f51
😎 Deploy Preview https://deploy-preview-1976--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/metrics/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1976 (0605ae9) into main (c7697bf) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   84.10%   84.23%   +0.12%     
==========================================
  Files         143      143              
  Lines        9018     9039      +21     
==========================================
+ Hits         7585     7614      +29     
+ Misses       1164     1158       -6     
+ Partials      269      267       -2     
Files Changed Coverage Δ
...-operator/api/v1alpha3/analysisdefinition_types.go 100.00% <ø> (ø)
...perator/api/v1alpha3/analysisdefinition_webhook.go 83.52% <100.00%> (+4.11%) ⬆️
.../controllers/common/analysis/operator_evaluator.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.34% <ø> (+1.29%) ⬆️
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 86.54% <100.00%> (+0.14%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review August 29, 2023 10:13
@odubajDT odubajDT requested review from a team as code owners August 29, 2023 10:13
@bacherfl
Copy link
Member

please also adapt the crd manifest in the helm directory

@odubajDT
Copy link
Contributor Author

please also adapt the crd manifest in the helm directory

thx, adapted

@github-actions github-actions bot added the helm label Aug 29, 2023
bacherfl
bacherfl previously approved these changes Aug 29, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT odubajDT merged commit 7fb8952 into keptn:main Aug 30, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm metrics-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants