Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): convert corner cases in SLO convertor #1999

Merged
merged 16 commits into from
Sep 1, 2023
Merged

feat(metrics-operator): convert corner cases in SLO convertor #1999

merged 16 commits into from
Sep 1, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Aug 31, 2023

Changes

Fixes: #1986

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c4fbd50
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f0a1646e8a6100081b284a
😎 Deploy Preview https://deploy-preview-1999--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1999 (712820d) into main (c6958fd) will increase coverage by 0.26%.
The diff coverage is 94.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
+ Coverage   84.12%   84.38%   +0.26%     
==========================================
  Files         143      144       +1     
  Lines        9039     9249     +210     
==========================================
+ Hits         7604     7805     +201     
- Misses       1165     1171       +6     
- Partials      270      273       +3     
Files Changed Coverage Δ
metrics-operator/converter/slo_converter.go 94.30% <94.27%> (-2.23%) ⬇️
metrics-operator/converter/common.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.89% <ø> (+1.22%) ⬆️
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 87.15% <94.60%> (+0.61%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review August 31, 2023 08:42
@odubajDT odubajDT requested a review from a team as a code owner August 31, 2023 08:42
@odubajDT odubajDT changed the title feat(metrics-operator): conver corner cases in SLO convertor feat(metrics-operator): convert corner cases in SLO convertor Aug 31, 2023
metrics-operator/converter/slo_converter.go Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.go Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.go Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.go Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
metrics-operator/converter/common.go Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.go Show resolved Hide resolved
metrics-operator/converter/slo_converter.go Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odubajDT 🙌

@odubajDT odubajDT merged commit 95e0953 into keptn:main Sep 1, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support corner cases in SLO convertor function
3 participants