Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics-operator): introduce .status.state in Analysis #2061

Merged
merged 10 commits into from
Sep 20, 2023
Merged

fix(metrics-operator): introduce .status.state in Analysis #2061

merged 10 commits into from
Sep 20, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Sep 8, 2023 •
edited

Changes

  • introduce .status.state in Analysis CRD
  • refactor analysis controller logic to make it testable
  • add unit tests
  • integration tests

Fixes: #2044

@netlify
Copy link

netlify bot commented Sep 8, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 75b4999
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650ad70be0915500087276a9
😎 Deploy Preview https://deploy-preview-2061--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/metrics/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

Merging #2061 (75b4999) into main (214af30) will increase coverage by 0.15%.
Report is 1 commits behind head on main.
The diff coverage is 91.48%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
+ Coverage   84.32%   84.48%   +0.15%     
==========================================
  Files         150      150              
  Lines        9623     9634      +11     
==========================================
+ Hits         8115     8139      +24     
+ Misses       1224     1214      -10     
+ Partials      284      281       -3
Files Changed Coverage Δ
metrics-operator/api/v1alpha3/analysis_types.go 100.00% <ø> (ø)
...etrics-operator/controllers/analysis/controller.go 82.69% <90.69%> (+10.52%) ⬆️
metrics-operator/api/v1alpha3/common.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.89% <ø> (+0.82%) ⬆️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 87.55% <91.48%> (+0.40%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the fix/2044/analysis-completion branch 2 times, most recently from 5a85a8f to 663b7b3 Compare September 19, 2023 12:25
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 19, 2023
@odubajDT odubajDT changed the title fix(metrics-operator): define completed state for Analysis fix(metrics-operator): introduce .status.state in Analysis Sep 19, 2023
@odubajDT odubajDT changed the title fix(metrics-operator): introduce .status.state in Analysis fix(metrics-operator): introduce .status.state in Analysis Sep 19, 2023
@github-actions github-actions bot added the helm label Sep 20, 2023
@odubajDT
fix(metrics-operator): define completed state for Analysis
9e1d6af 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix after rebase
d3c5d9d 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
add descriptive comments
24ddb35 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
add unit tests
7c76b7e 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
update helm charts
ab6c192 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
adapt integration tests
1beb977 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
do not proceed if the analysis is completed
81eca1c 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix issues
68adbff 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review September 20, 2023 08:04
@odubajDT odubajDT requested review from a team as code owners September 20, 2023 08:04
@odubajDT
pr review
4401685 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
bacherfl previously approved these changes Sep 20, 2023
View reviewed changes
@odubajDT
adapt docs
75b4999 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit b08b4d8 into keptn:main Sep 20, 2023
34 checks passed
This was referenced Sep 20, 2023
Merged
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation helm metrics-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis CRD Status: Pass/Warning properties are omitted if Analysis evaluation failed
3 participants
@odubajDT @bacherfl @RealAnna